Patch: don't save tiles that are equal to the default tile

[Dmitry Kazakov]

On Tue, Mar 16, 2010 at 4:33 PM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Tue, 16 Mar 2010, Dmitry Kazakov wrote:
>
> > I don't think we need this.
> >
> > KisTileHashTableIterator returns the number of non-default tiles, or
> (more
> > precisely) the number of preallocated tiles. After you fixed the extents
> > bug, these terms coincide. So this check is superfluous.
>
> Isn't it so that within a rectangle of allocated tiles there can be
> unallocated, default pixel, tiles?
>

What do you mean? Which rectangle? extents?
If they are unallocated, they are not returned by the iterator. If they are
allocated, but empty (store default value), this is some subtle bug of the
calling code, i guess. This can happen if we use non-const iterator for
reading, or if we just direct copy data from empty device, but this is quite
rare case, i think.



-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100316/5cdaec96/attachment.htm