KisSliderSpinBox api change

[Sven Langkamp]

On Sat, Mar 13, 2010 at 9:23 AM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Saturday 13 March 2010, Sven Langkamp wrote:
> > Hi,
> >
> > when looking at the recent changes to use the new slider I found several
> > places where is wasn't used correctly. (using the integer methods that
> does
> > consider the factor)
> > Therefor I propose the api changed in the attached patch. By not longer
> > inheriting from QAbstractSlider it hides the internal api.
> >
> > That way we can still use the current value/setValue and valueChanged
> > signal.
> >
> > When changing a slider the signal connection needs to be checked, because
> > the old slider often had different parameter there.
> > I know it's a bit stupid to change it now, but it reduces the risk of
> using
> > the api in the wrong way.
>
> Does this make it impossible to use the slider for integer values? We have
> a
> number of places where we use integers, like opacity etc.
>

Not impossible, you could set decimals to 0 and round the resulting values.
If we don't make the change than you have to be careful to use the right
method.
At the moment e.g. the gradient tool threshold is broken because of that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100313/f5484dc5/attachment.htm