KisSliderSpinBox api change

Sven Langkamp sven.langkamp at gmail.com
Sat Mar 13 02:37:52 CET 2010


Hi,

when looking at the recent changes to use the new slider I found several
places where is wasn't used correctly. (using the integer methods that does
consider the factor)
Therefor I propose the api changed in the attached patch. By not longer
inheriting from QAbstractSlider it hides the internal api.

That way we can still use the current value/setValue and valueChanged
signal.

When changing a slider the signal connection needs to be checked, because
the old slider often had different parameter there.
I know it's a bit stupid to change it now, but it reduces the risk of using
the api in the wrong way.


Sven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100313/d9250eb1/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: slider.diff
Type: text/x-patch
Size: 11684 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20100313/d9250eb1/attachment.diff 


More information about the kimageshop mailing list