KisSelection vs. KisPixelSelection

Boudewijn Rempt boud at
Mon Jun 21 21:27:26 CEST 2010

On Sunday 20 June 2010, Sven Langkamp wrote:
> Both classes share only a few methods that are common to both. At the same
> time they have lots of stuff that is specific to one of them like updating
> the projection in KisSelection or manipulation methods in pixel selection.
> It would make more sense to put the methods that are the same in both
> classes into a shared base class.

Hm... I'm not completely following the issues Dmitry has with the current 
design, but reflecting on the current code, I think it's a bit ugly that 
KisSelection _is_ the projection. How about something like:

Make a KisSelection class that is not a paint device. Make it own:

* KisPixelSelection::KisPaintdevice
* KisVectorSelection
* and a KisPaintDevice for the projection.

similar to KisImage?

Boudewijn Rempt |

More information about the kimageshop mailing list