KisSelection vs. KisPixelSelection

Sven Langkamp sven.langkamp at gmail.com
Sun Jun 20 13:18:10 CEST 2010


On Sun, Jun 20, 2010 at 12:58 PM, Dmitry Kazakov <dimula73 at gmail.com> wrote:

>
> I've wrote about this issue:
> http://wiki.koffice.org/index.php?title=Krita/KisSelection_Issues
>
> Sven, could you comment on it?
>

I don't agree. Currently KisSelection is designed to be basically read-only
for tools and filters. Inheriting from KisPixelSelection would break that.
Suddenly it would be possible to edit the KisSelection even though it is
just the projection. Additionally selection could be nested, because you
could put a KisSelection into a KisSelection. It's the same the relation as
for group layer and normal layers.

If you want to reduce the code duplication it's probably better to use a
common base class for them.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100620/2c88e114/attachment.htm 


More information about the kimageshop mailing list