Transaction API refactoring done

[Dmitry Kazakov]

I did some investigation about unittests, so what fails in image for me:

          6 - krita-image-KisFixedPaintDeviceTest (Failed)

I don't know whose is this. Last success Apr 23.

         29 - krita-image-KisConvolutionPainterTest (Failed)
         49 - krita-image-KisAsyncMergerTest (Failed)

These two are due to fixes in blur filter. I'll check them.

         62 - krita-image-KisPaintopRegistryTest (Failed)
         63 - krita-image-KisPaintopSettingsTest (Failed)

There is some bug in MyPaint brushes, because both the tests crash on exit:

PASS   : KisPaintopRegistryTest::testCreation()
PASS   : KisPaintopRegistryTest::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped
********* Finished testing of KisPaintopRegistryTest *********
qttest(24267)/krita (general) MyPaintBrushResource::load:        we only
read version 2 .myb files
Fatal Error: Accessed global static 'BrushSettingDefinitions
*s_brush_setting_definitions()' after destruction. Defined at
/home/devel/kde-src/koffice.TRUNK/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp:204

Program received signal SIGABRT, Aborted.
[Switching to Thread 0x7fffdd860710 (LWP 24271)]
0x00007ffff18269a5 in raise () from /lib64/libc.so.6
(gdb) bt
#0  0x00007ffff18269a5 in raise () from /lib64/libc.so.6
#1  0x00007ffff1827ea6 in abort () from /lib64/libc.so.6
#2  0x00007ffff34283d4 in qt_message_output(QtMsgType, char const*) () from
/usr/lib64/libQtCore.so.4
#3  0x00007ffff34285a2 in ?? () from /usr/lib64/libQtCore.so.4
#4  0x00007ffff3428745 in qFatal(char const*, ...) () from
/usr/lib64/libQtCore.so.4
#5  0x00007fffdd86e1ed in <anonymous struct>::operator->(void)
(this=0x7fffdda8c840)
    at
/home/devel/kde-src/koffice.TRUNK/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp:204
#6  0x00007fffdd86eb5c in MyPaintBrushResource::load (this=<value optimized
out>)
    at
/home/devel/kde-src/koffice.TRUNK/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp:396
#7  0x00007fffdd87b5be in
KoResourceServer<MyPaintBrushResource>::loadResources (this=<value optimized
out>, filenames=<value optimized out>)
    at /home/devel/kde-src/koffice.TRUNK/libs/widgets/KoResourceServer.h:132
#8  0x00007ffff690f727 in KoResourceLoaderThread::run (this=0x3d49300) at
/home/devel/kde-src/koffice.TRUNK/libs/widgets/KoResourceServerProvider.cpp:73
#9  0x00007ffff34301c5 in ?? () from /usr/lib64/libQtCore.so.4
#10 0x00007ffff31a2a3f in start_thread () from /lib64/libpthread.so.0
#11 0x00007ffff18c4c3d in clone () from /lib64/libc.so.6
#12 0x0000000000000000 in ?? ()


There are random crashes and hang-ups of KisThreadedApplicatiorTest and
KisFilterJobTest. I think there is some bug (?) in threadweaver-related
code. It looks like the thread is not ended after return from
weaver->finish(). I don't know what to do with this code.

          4 - krita-libbrush-KisAutobrushTest (Failed)
          8 - krita-mypaint-KisMyPaintSurfaceTest (Failed)
         10 - krita-plugins-formats-tiff_test (Failed)
         14 - krita-plugin-format-xcf_test (Failed)
         16 - krita-cs-ko_ctl_channel_test (Failed)
         17 - krita-cs-ko_rgb_32f_test (Failed)

These ones happen on clean trunk too.

-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100612/db80eeae/attachment.htm