Impasto discussion

[JL VT]

I'd like to perform thread necromancy now that I have a worthy update
to mention:

http://pentalis.org/kritablog/?p=157

I decided to follow the Phong Illumination Model to set the color of
the bumps, and for now I'm only using the pixels above and below, and
right and left of the reference pixel to calculate its normal vector
(and therefore, indirectly, "inclination/tilt").

The main references being, as the blog post highlights:
http://www.mini.pw.edu.pl/~kotowski/Grafika/IlluminationModel/Index.html
http://www.gamedev.net/columns/hardcore/cgbumpmapping/

The source of the program is:
http://pentalis.org/kritablog/wp-content/uploads/2010/07/bumpy_source.txt


On Wed, Jul 7, 2010 at 4:05 PM, JL VT <pentalis at gmail.com> wrote:
> ...
> Now, if you don't have any concern (and even if you do), what are the
> classes I should study to start implementing this design?. Should I
> create a new class?, if so, where should I store it?, what other
> classes should it inherit?. Also a quick pointer on how the eraser
> mode was created is appreciated.
>
>...

Now onto the questions.
I'm still a bit lost, so I'd like to narrow my inquiries to something
concrete. Please validate these hypotheses I have:
---The source dealing with the impasto bumpmapping should go in
koffice/krita/image , in a new class, probably base_impasto.cpp or
impasto.cpp, devoted to describe a layer subject to being bumpmapped
and store the projection.
---The source dealing with the 5th channel (the height channel) in new
colorspaces should go in koffice/libs/pigment/colorspaces , in new
classes, probably called OLDNAMEHeightEnhanced.cpp or
OLDNAMEImpastoCapable.cpp .
---I can operate directly in the main branch of Krita because adding
those new classes shouldn't break the program for anyone.

Correct/Agreed?.