koffice

[Adam]

Hi,
first I want to say, that I like the new handling of local selections very  
much. I've played a little bit with it and found a few bugs, most of them  
are probably not caused by your changes, but now that you are familiar  
with that code, you maybe want to fix them :)

o crash, if duplicating layer with local selection
o open krita -> create local selection => selection decoration is not  
displayed
o do not enable/switch to local selection layer, if clicking on it (keep  
the layer active, so that you can draw etc)
  - alternatively disable all tools but selection
o do not allow more than one local selection per layer
  - alternatively make them work
o open krita -> create new layer -> in the new layer create local  
selection => selection is not on the full image
o open krita -> create local selection -> create new layer -> move local  
selection to new layer => the preview is not updated or incorrect.
  - may be caused by the previous bug
o i got a crash, but i can't reproduce. here is the backtrace, maybe you  
can find something: http://www.pastebin.ca/1792057
   (i'm just sending it, because there is KisSelection in the backtrace,  
could be unrelated)

additionally you probably forgot to remove  
commands/kis_deselect_local_selection_command and  
commands/kis_reselect_local_selection_command from svn. (the command for  
that is "svn rm filename.foo") :)

regards, adam



On Tue, 09 Feb 2010 22:17:11 +0100, Marc Pegon <pe.marc at free.fr> wrote:

> SVN commit 1087945 by pegon:
>
> Fixed bug 210865 concerning local selections. To create a new local  
> selection : make a global selection, then right click on layer -> local  
> selection. A third property has beed added to selection masks - activity  
> (still needs an icon) - so that the effect of the selection mask is  
> independant to its visibility.
> Only one selection mask per layer can be active at the same time.
> The "deselect" and "deselect all" actions only apply to the global  
> selection.
> Note that when you create a local selection from a global selection, the  
> global selection is not deleted (we may change this behaviour), it's  
> only "hidden" (disabled) by the local selection : the global selection  
> is only active and visible when no local selection is active.
> Thus, to modify or make a global selection, no local selection should be  
> active.
> To modify an existing local selection : activate it, and use the  
> selection tool.
>
>
>
>  M  +0 -2      krita/image/CMakeLists.txt
>  M  +0 -2      krita/image/commands/kis_selection_commands.h
>  M  +8 -5      krita/image/kis_base_node.h
>  M  +11 -6     krita/image/kis_layer.cc
>  M  +8 -4      krita/image/kis_paint_device.cc
>  M  +3 -2      krita/image/kis_paint_device.h
>  M  +16 -0     krita/image/kis_selection.cc
>  M  +2 -0      krita/image/kis_selection.h
>  M  +56 -0     krita/image/kis_selection_mask.cpp
>  M  +15 -0     krita/image/kis_selection_mask.h
>  M  +35 -6     krita/ui/kis_mask_manager.cc
>  M  +2 -0      krita/ui/kis_mask_manager.h
>  M  +8 -0      krita/ui/kis_node_model.cpp
>  M  +1 -2      krita/ui/kis_selection_decoration.cc
>  M  +6 -16     krita/ui/kis_selection_manager.cc
>  M  +7 -4      libs/pigment/colorspaces/KoAlphaColorSpace.cpp
>
>
> http://websvn.kde.org/?view=rev&revision=1087945


-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/