Broken unittests

Cyrille Berger cberger at cberger.net
Tue Aug 31 10:04:59 CEST 2010


On Monday 30 August 2010, Boudewijn Rempt wrote:
> > Well this is the same problem with the xcf actually. The error is of 1. I
> > am  not sure whether it is acceptable or not. I am also unsure where it
> > comes from. Both tests pass on branch/2.2.
> 
> Hrm. This sounds pretty serious to me. It would mean that at some point we
> have started displaying our own files differently as well.
Yes.

It is quiet possible that the commit that triggered it is:
------------------------------------------------------------------------
r1118243 | berger | 2010-04-24 08:02:19 +0200 (Sat, 24 Apr 2010) | 2 lines

use the IntegerMath functions for a major speed improvement


I will try to investigate this evening.

> > (on a side note, I would prefer if the 
> > test are not marked as EXPECT_FAIL, it is the best way to forget about
> > them  alltogether...)
> 
> I sort of agree -- but on the other hand, many tests have ten or so
> subtests, and if one of them fails, people don't notice when more start
> failing.
It is a good point, maybe we should list the EXPECT_FAIL on the wiki ?

-- 
Cyrille Berger


More information about the kimageshop mailing list