Canvas rotation preliminary patch

Boudewijn Rempt boud at valdyas.org
Fri Aug 13 10:30:54 CEST 2010


On Friday 13 August 2010, Dmitry Kazakov wrote:
> Hi, All!
> 
> The reviewboard seems to be down right now, so i'm sending the patch here.
> http://dimula73.narod.ru/coordinates_refactor_v6.patch
> 
> What is implemented:
> o Mirroring Ctrl+I
> o Rotation Ctrl+[, Ctrl+]
> o Reset canvas Ctrl+'

Sounds good.

> Known bugs:
> 1) I still do not change the scroll area of KoCanvasController, so the
> canvas picture may be cropped when rotated

Did you try updating the document size?

> 2) There is a strange bug:
>     1. Switch to openGL canvas
>     2. Switch back QPainter canvas
>     3. Open configuration dialog, do not change anything, press ok
>     4. Try to zoom: KisPrescaledProjection in NOT updated

I'd run in valgrind to check whether there's uninitialized jump or something like that. 

> I don't know what is the reason of this bug yet, but it's really difficult
> to reproduce ;)

It sounds tricky indeed.

-- 
Boudewijn Rempt | http://www.valdyas.org


More information about the kimageshop mailing list