Yet another bug. This time filters vs selections

[Dmitry Kazakov]

> I commited a fix to the filter so that now at least it works like in
> previous version of Krita.
>

That's it: "at least works" =(



>
> On Tuesday 08 September 2009, Dmitry Kazakov wrote:
> > What can you say about this?
> > For me, i like the second case for simplicity of the design and
> > maintainability, but i'm afraid of some perfomance problems.
> That's why we choosed the first solution, with binarization of the mask.
>

Quite strange (at least) assumption. We should think from user's point of
view. That is absolutely not obvious for a user, that all the transparency
masks blend colors and draw semi-transparent projections as
semi-transparent, BUT transparency masks of Filter Masks do not and they use
binary transparency instead. I think it's bad. Very bad. All the tools
should work in a uniform way (that is one of the main usability principles).

That's why i suggested 2 solutions for that. There is another solution -
just remove KisSelection from a KisMask class and add KisTransparencyMask
hidden child instead. This solution would work quite well. BUT this won't
solve other uses of KisFilter::process(...,selection).


But the second solution might be worth investigation, at least, I will need
> to use such a solution for Shiva based filters, since OpenShiva doesn't know
> anything about masks and selections.
>

I don't know how to make a benchmark of that, i guess, it would be
interesting to look at. We could test for the cold-cache problem at least.
(We could assume that big holes in a selection are quite rare and not very
important).


> Btw, where are filters called form in Krita? I know only three places:
> > - adj. layers
> > - filter masks
> > - filter menu (actually, uses masks)
> and scripts and macro, and the filter preview model and the filter brush.
>
Not much really:
fgrep 'process(' -R ./ |grep -v svn |grep -v '::process(' |grep -v void
|grep -v test|less

So it won't be so difficult if we decide to change something =)

-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20090909/a3c919b7/attachment.htm