Review request: Masks support compositeOps and opacity

[Boudewijn Rempt]

On Wednesday 28 October 2009, Dmitry Kazakov wrote:
> > > I've done tests. Kis{,Base}Node tests are done successfully, but some
> >
> > Masks
> >
> > > and Selections tests fail with segmentation. Could you check whether
> > > this is a regression or not?
> >
> > well, they didn't fail when we branched 2.1: in fact, we had 100% success
> > on
> > all tests at that moment. However, I enabled your tile engine and the
> > pyramid,
> > and that caused some tests to fail.
> 
> Wait.. My working copy doesn't have new tile engine enabled! It hasn't been
> updated to your commit yet! So, that is not the reason =)
> 
>  I can check whether there are more
> 

With patch and tiles3:

93% tests passed, 6 tests failed out of 81

The following tests FAILED:
          8 - krita-image-KisIteratorTest (Failed)
         15 - krita-image-KisTransactionTest (Failed)
         18 - krita-image-KisFilterMaskTest (Failed)
         29 - krita-image-KisCropVisitorTest (Failed)
         72 - krita-image-KisTransformWorkerTest (Failed)
         73 - krita-image-KisTransparencyMaskTest (Failed)
Errors while running CTest

With tiles3, without your patch:

95% tests passed, 4 tests failed out of 81

The following tests FAILED:
          8 - krita-image-KisIteratorTest (Failed)
         15 - krita-image-KisTransactionTest (Failed)
         29 - krita-image-KisCropVisitorTest (Failed)
         72 - krita-image-KisTransformWorkerTest (Failed)
Errors while running CTest

with tiles1, without your patch:

100% tests passed, 0 tests failed out of 81


> > failures with this patch, of course.
> >
> > Btw, since enabling the new tile engine, saving is broken. I think Lukas
> > is creating a bug for that.
> 
> Strange, saving worked in August.
> 

right now, the layer that is saved is 3 bytes in size, there must be something 
weird going on when saving, it isn't recomposition when loading that's the 
problem.

Have you also seen the undo problem? I'll ask Enkithan to make a bug report.

-- 
Boudewijn Rempt | http://www.valdyas.org