koffice/krita/image

[Boudewijn Rempt]

Moving discussion to the mailing list again...


> > I'll cc the the mailing list, since this is a broader issue.
> >
> > > Could you explain me how does this change help blur filter?
> >
> > Not really, maybe Cyrille can -- it's something to do with the
> > convolution painter.
> 
> Cyrille, ping!
> 
> > > The point is, we can't do a bitBlt() here as needRect of the filter
> > > might be much bigger than actual rc, given to this function. Actual
> > > needRect
> >
> > is
> >
> > >  calculated in KisLayer::updateProjection and is know only there.
> >
> > Maybe it's better to have it in kis_filter_mask instead? For now it's
> > unfortunately needed, and I think a refactor of this thing should wait
> > until
> > 2.2.
> 
> Unfortunately, not. NeedRects of all the masks have to be be calculated
> together. Take a look at KisLayer::masksChangeRect/masksNeedRect functions.

Fortunately, it works for those filters that need a copy, namely the 
convolution filters.


> It means that filters do not conform KisFilter's interface of src and dst.
> And we shouldn't introduce workaround for it. We just need to make the
> filter follow the rules and fix it =) (i hope, blur filter is the only
>  one?)

All convolution filters have the same problem. It's not a problem with the 
filters per se, but with the convolution painter.


-- 
Boudewijn Rempt | http://www.valdyas.org