Fwd: Re: koffice/krita/ui

[LukasT.dev@gmail.com]

FindGLEW.cmake is problematic, did you know that?

Lukas

----------  Forwarded Message  ----------

Subject: Re: koffice/krita/ui
Date: Monday 07 December 2009
From: Maciej Mrozowski <reavertm at gmail.com>
To: "LukasT.dev at gmail.com" <lukast.dev at gmail.com>

On Monday 07 of December 2009 15:54:06 dev  wrote:
> Hi, this is correct fix. I'm author of that code. Thank you for fix, I
>  don't compile without opengl, you do?

Hi
Yeah, I'm packaging KDE SC for Gentoo and I happen to occasionally test 
various compilation configurations in trunk. And when I feel some fix is 
harmless or obvious, I commit it right away. Feel free to spank me when I'm 
wrong :)

Btw, one little warning from me - if you happen to (or going to) have gluon on 
your system, be advised that they bundle and *install* FindGLEW.cmake (and 
some others) modules that is incompatible with koffice one, and as it's 
installed in <prefix>/share/apps/cmake/modules - it shadows koffice private 
one causing libkritaui linking issues.

> On Monday 07 December 2009 04:14:12 Maciej Mrozowski wrote:
> > SVN commit 1059624 by mmrozowski:
> >
> > Fix building krita without OpenGL
> >
> >
> > CCMAIL: kimageshop at kde.org
> >
> >  M  +4 -1      kis_3d_object_model.h
> >
> >
> > --- trunk/koffice/krita/ui/kis_3d_object_model.h #1059623:1059624
> > @@ -55,8 +55,9 @@
> >      //void parseModel();
> >      void parseMaterial(const QString &fileName);
> >
> > -
> > +#ifdef HAVE_OPENGL
> >      GLuint displayList();
> > +#endif // HAVE_OPENGL
> >
> >  private:
> >      QString m_fileName;
> > @@ -71,7 +72,9 @@
> >      void debug(Material m);
> >
> >      bool m_cached;
> > +#ifdef HAVE_OPENGL
> >      GLuint m_displayList;
> > +#endif // HAVE_OPENGL
> >  };
> >
> >  #endif // KIS_3D_OBJECT_MODEL_H
> 

-- 
regards
MM

-------------------------------------------------------