Fix for crop tool crash

Sven Langkamp sven.langkamp at gmail.com
Mon Aug 24 14:17:45 CEST 2009


On Mon, Aug 24, 2009 at 2:09 PM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Mon, 24 Aug 2009, Cyrille Berger wrote:
>
> > Hi,
> >
> > We discussed this on IRC. Here is the conclusion:
> > * paintdevice colorspaces belongs to the paintdevice, therefor they have
> a
> > short/unpredictable life expectency, you should only use them as long as
> you
> > are certain that the paintdevice won't be deleted
> > * if you need to keep a pointer of the color space (like in a KoColor),
> you
> > need to ask the KoColorSpaceRegistry for a permanent colorspace (see the
> > permanentColorspace function)
> >
> > In this case, since it's a property of the layer. Storing the id/name in
> the
> > model would be the way to go.
>
> I don't get this last bit -- can you unpack a bit?


At the moment KisCompositeOpsModel stores the pointers to the composite ops
which are deleted when the colorspace is deleted.
Instead of the pointer the id/name should be saved as Cyrille said.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20090824/9c97f450/attachment.htm 


More information about the kimageshop mailing list