Need some help with colorspaces
Cyrille Berger
cberger at cberger.net
Tue Aug 4 13:28:57 CEST 2009
On Tuesday 04 August 2009, Boudewijn Rempt wrote:
> On Tue, 4 Aug 2009, Dmitry Kazakov wrote:
> > > Does it happen with all colorspace ?
> >
> > I've just fixed the bug. =(
> > It is in KoColorSpace::bitBlt. There was some strange rowStride
> > post-calculation in it. The patch is in attachment. Should i put it to
> > reviewboard or just commit?
>
> Looks good to me. It would be wonderful to have a unittest for this in
> pigment... Althought bitblt is also tested in the krita/image unittests,
> but they have been failing for a long time.
Well we clearly need both tests :) so that we know which functions fails and
when. But I must admit total lazyness, especially given the relative few
number of bugs found (and therefor fixed) in pigment for more than a year ;) (I
know it's not an excuse :) )
--
Cyrille Berger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20090804/f72754de/attachment.htm
More information about the kimageshop
mailing list