paintops

Cyrille Berger cberger at cberger.net
Tue May 29 23:56:44 CEST 2007


> What do you think?
that the offset and other clone options are also out of place in 
KisPaintInformation :)

KisPaintInformation should be limited to dynamic information that changes for 
each strokes. And offset/healing are "static" options (it can be changed 
between each strokes, but then the KisPaintOp is recreated between two 
strokes anyway), and one can imagine that the pressure could somehow affect 
the offset (anyway, is it usefull ?) but the base offset remains constant 
during the stroke.

> PS. an alternative is to for the tool send an inherited class of
> KisPaintInfo and have the paintOp use dynamic_cast<> to try to get the
> correct type.
>
> PSPS. Another alternative is for the tool to populate the properties of the
> paintOp directly instead of going through KisPainter. This means the tool
> needs to do dynamic_cast on the paintOp.

The real alternative is to have offset/healing in a KisConfigurationPaintOp. 
And getting ride of the duplicate tool is really something which should do in 
2.0. The main problem was to be able to set the offset, as a KisPaintOp can't 
receive user interaction before the user starts painting. And then the 
healing and perspective option can be moved to the paintop's config widget 
and they should have been send if I had understood better that part of Krita 
at that time :)

-- 
Cyrille Berger


More information about the kimageshop mailing list