deskew plugin

[Michael Thaler]

On Saturday 17 March 2007 16:11, Boudewijn Rempt wrote:

> Cool! Just check it in in the krita-plugins project, that will get a
> release together with Krita 1.6.3.

I copied the code from my Krita source tree and tried to compile it in 
krita-plugins, but I get compile errors. Appaerently the compiler does not 
find some header files, but I don't really understand what these messages 
mean.


michi:/usr/local/src/kde/krita-plugins/build-debug/filters/deskew$ make
if /bin/sh ../../libtool --silent --tag=CXX --mode=compile 
g++ -DHAVE_CONFIG_H -I. -I../../../filters/deskew -I../.. -I../../../filters/deskew/../../../sdk -I../../../filters/deskew/../../../core -I../../../filters/deskew/../../../kritacolor/ -I../../../filters/deskew/../../../ui  -I/usr/include/kde -I/usr/share/qt3/include -I.   -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -fno-builtin -g3 -fno-inline -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common  -MT 
kis_deskew_filter_plugin.lo -MD -MP -MF ".deps/kis_deskew_filter_plugin.Tpo" -c -o 
kis_deskew_filter_plugin.lo ../../../filters/deskew/kis_deskew_filter_plugin.cc; 
\
        then 
mv -f ".deps/kis_deskew_filter_plugin.Tpo" ".deps/kis_deskew_filter_plugin.Plo"; 
else rm -f ".deps/kis_deskew_filter_plugin.Tpo"; exit 1; fi
In file included from /usr/local/include/kis_paint_device.h:31,
                 from /usr/local/include/kis_filter.h:31,
                 from ../../../filters/deskew/kis_deskew_filter.h:24,
                 from ../../../filters/deskew/kis_deskew_filter_plugin.cc:23:
/usr/local/include/kis_global.h:23:10: error: #include expects "FILENAME" or 
<FILENAME>
In file included from /usr/local/include/kis_paint_device.h:33,
                 from /usr/local/include/kis_filter.h:31,
                 from ../../../filters/deskew/kis_deskew_filter.h:24,
                 from ../../../filters/deskew/kis_deskew_filter_plugin.cc:23:
/usr/local/include/kis_colorspace.h:22:10: error: #include expects "FILENAME" 
or <FILENAME>
In file included from /usr/local/include/kis_color.h:25,
                 from /usr/local/include/kis_paint_device.h:35,
                 from /usr/local/include/kis_filter.h:31,
                 from ../../../filters/deskew/kis_deskew_filter.h:24,
                 from ../../../filters/deskew/kis_deskew_filter_plugin.cc:23:
/usr/local/include/kis_profile.h:27:10: error: #include expects "FILENAME" or 
<FILENAME>
In file included from ../../../filters/deskew/kis_deskew_filter_plugin.cc:23:
../../../filters/deskew/kis_deskew_filter.h:26:33: error: 
kis_filter_strategy.h: No such file or directory
../../../filters/deskew/kis_deskew_filter.h:28:34: error: 
kis_transform_worker.h: No such file or directory
/usr/local/include/kis_image.h:168: error: 'INTENT_PERCEPTUAL' was not 
declared in this scope
/usr/local/include/kis_colorspace.h:147: error: 'icColorSpaceSignature' does 
not name a type
/usr/local/include/kis_colorspace.h:249: error: 'INTENT_PERCEPTUAL' was not 
declared in this scope
/usr/local/include/kis_colorspace.h:281: error: 'INTENT_PERCEPTUAL' was not 
declared in this scope
/usr/local/include/kis_colorspace.h:437: error: 'icColorSpaceSignature' does 
not name a type
/usr/local/include/kis_profile.h:44: error: expected ',' or '...' 
before 'profile'
/usr/local/include/kis_profile.h:51: error: 'icColorSpaceSignature' does not 
name a type
/usr/local/include/kis_profile.h:52: error: 'icProfileClassSignature' does not 
name a type
/usr/local/include/kis_profile.h:57: error: 'cmsHPROFILE' does not name a type
/usr/local/include/kis_profile.h:76: error: 'cmsHPROFILE' does not name a type
/usr/local/include/kis_profile.h:77: error: 'icColorSpaceSignature' does not 
name a type
/usr/local/include/kis_profile.h:78: error: 'icProfileClassSignature' does not 
name a type
/usr/local/include/kis_profile.h: In function 'bool operator==(const 
KisProfile&, const KisProfile&)':
/usr/local/include/kis_profile.h:94: error: 'const class KisProfile' has no 
member named 'm_profile'
/usr/local/include/kis_profile.h:94: error: 'const class KisProfile' has no 
member named 'm_profile'
/usr/local/include/kis_paint_device.h: At global scope:
/usr/local/include/kis_paint_device.h:247: error: 'INTENT_PERCEPTUAL' was not 
declared in this scope
make: *** [kis_deskew_filter_plugin.lo] Error 1

Somebody knows how to fix this?

I improved the plugin a bit. It is now (kind of) colorspace independent. The 
analyzing algorithm uses RGB, but the actual rotation of the image is done by 
the transform_worker, which should be colorspace independent.

I also removed the options from the preview widget. Still not sure if we 
should keep it or not because it uses the algorithm on a scaled down version 
of the original image, which might not work correctly.

Greetings,
Michael