branches/koffice/1.6/koffice/krita

[Schleimer, Ben]

Hi Cyrille,

--- Cyrille Berger <cberger at cberger.net> wrote:

> > * extent() and exactBounds() vs rawData() -- we have discussed this in the
> > past. It's not in 1.6, but in trunk we separated the iterators into const
> > and non-const interators. This should, in theory, make it possible to set
> > the exact extent of an image (by assuming that a non-const iterator writes
> > over the whole area it is created on). Not sure whether we did that,
> > though. I think not...
> No we didn't. The const/non-const things was mostly to enforce that we can't 
> write on the source paint device. Now, we probably can use that for making 
> optimization :)

Yeah!! that would be nice. And maybe eliminate the overlap between extent() and exactBounds so we
can perserve some abstraction layering between the KisPaintDevice and those which use it. :)

> 
> > * chunked rendering for filters. I should checkout 1.6 again to see about
> > it -- I'm still not sure that putting the chunking inside the filters
> > doesn't make life more complicated for filter writers, but I'll check 1.6
> > code before I continue with my threaded applicator class in trunk.
> 
> isn't the chunking done outside in this patch ?

The chunking isn't done anymore. The most of the filters in 1.6 do not work correctly if the
filtering is done per chunk so I changed the preview widget as per the blog. Unfortunately, now it
occasionally crashes which I'm trying to debug :(.