branches/koffice/1.6/koffice/krita

[Boudewijn Rempt]

On Wednesday 14 March 2007, you wrote:
> SVN commit 642525 by schleimer:
>
> Fixed KisImage copy constructor. Made KisPreviewWidget work by scaling the
> KisImage and then filtering instead filtering in tiles which broke plugins.
> This works for selections too. Removed the timers from the users of
> KisPreviewWidget because it updates internally now.

Google just alerted me to your blog -- http://codetalk.blogspot.com/, added to 
my akregator -- and I noticed two things that I feel need discussion on the 
main mailing list:

* extent() and exactBounds() vs rawData() -- we have discussed this in the 
past. It's not in 1.6, but in trunk we separated the iterators into const and 
non-const interators. This should, in theory, make it possible to set the 
exact extent of an image (by assuming that a non-const iterator writes over 
the whole area it is created on). Not sure whether we did that, though. I 
think not... I'm also wondering whether we should do a read-ahead for the 
iterators, getting the the data out of the tiles ahead of time.

* about selection scaling: have you tested the image/layer resize dialogs and 
the transform tool for regressions after your changes?

* chunked rendering for filters. I should checkout 1.6 again to see about 
it -- I'm still not sure that putting the chunking inside the filters doesn't 
make life more complicated for filter writers, but I'll check 1.6 code before 
I continue with my threaded applicator class in trunk.

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20070315/b5b0a62d/attachment.pgp