exactBounds

[Sven Langkamp]

On 7/18/07, Casper Boemann <cbr at boemann.dk> wrote:
> On Wednesday 18 July 2007 17:47, Sven Langkamp wrote:
> > On 7/18/07, Casper Boemann <cbr at boemann.dk> wrote:
> > > On Wednesday 18 July 2007 17:39, Sven Langkamp wrote:
> > > > On 7/18/07, Casper Boemann <cbr at boemann.dk> wrote:
> > > > > On Wednesday 18 July 2007 13:33, Sven Langkamp wrote:
> > > > > > In bltMask there is:
> > > > > > srcRect &= selMask->exactBounds();
> > > > > >
> > > > > > I think this should be:
> > > > > > if(selMask datamanager defaultpixel == select min)
> > > > > >     srcRect &= selMask->exactBounds();
> > > > >
> > > > > sounds correct
> > > > >
> > > > > > What's equivalent to SELECT_MIN in a normal paintdevice?
> > > > >
> > > > > There is none - it's up to the color space to know and interpret
> > > >
> > > > Then it would probably be better to remove that line and give the
> > > > caller the  responsibility to update the correct rect.
> > >
> > > what line will you remove?
> >
> > srcRect &= selMask->exactBounds();
> no no your first suggestion with the if is fine
>
> for the selection it's ok to check against SELECT_MIN etc
>
> it's only for normal colorspaces that it is not possible
Unfortunatly bltMask gets a normal KisPaintDevice as mask, which make
it impossible to determine if defaultpixel can be treated like
SELECT_MIN