Layers and shared pointers and unittests

Boudewijn Rempt boud at valdyas.org
Thu Jan 5 17:45:04 CET 2006


Is there a good reason to keep layers around under their shared pointer guise? 
We won't have many layers not in an image anymore, we used to use them in 
many places but we should use paint devices now; and if layers are owned by
images, images should delete them.

Btw, I've fixed the krita/core unittests. Two things:

    Unexpected failures:
        /home/boud/koffice/krita/core/tests/kis_integer_maths_tester.cpp[55]: 
failed on "(int)UINT8_BLEND(255, 0, 128)" result = '127' expected = '128'
        /home/boud/koffice/krita/core/tests/kis_integer_maths_tester.cpp[56]: 
failed on "(int)UINT8_BLEND(255, 128, 128)" result = '191' expected = '192'
        /home/boud/koffice/krita/core/tests/kis_integer_maths_tester.cpp[57]: 
failed on "(int)UINT8_BLEND(128, 64, 255)" result = '127' expected = '128'
        /home/boud/koffice/krita/core/tests/kis_integer_maths_tester.cpp[78]: 
failed on "(int)UINT16_BLEND(65535, 0, 32768)" result = '32767' expected = 
'32768'
        /home/boud/koffice/krita/core/tests/kis_integer_maths_tester.cpp[79]: 
failed on "(int)UINT16_BLEND(65535, 32768, 32768)" result = '49151' expected 
= '49152'
        /home/boud/koffice/krita/core/tests/kis_integer_maths_tester.cpp[80]: 
failed on "(int)UINT16_BLEND(32768, 16384, 65535)" result = '32767' expected 
= '32768'

And I wish I could get the unittests at least compiled, but preferably run as 
part of an ordinary targetless (unser)make run. Anyone an idea?


-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20060105/f1202e13/attachment.pgp


More information about the kimageshop mailing list