Is this really right?

Boudewijn Rempt boud at valdyas.org
Thu Feb 2 07:05:02 CET 2006


On Wed, 1 Feb 2006, Cyrille Berger wrote:

> > In the convolution painter, we've got lines like this:
> >
> > memcpy( pixelPtrCache.data() + krow * kw, pixelPtrCache.data() + lastvalid,
> > kw*sizeof(Q_UINT8*));
> >
> > Do we really want to size of a pointer to a byte; or the size of a byte
> > here?
> we really want the size of a pointer as we pixelPtrCache.data() is a
> Q_UINT8**, it's more likely that we try to copy one pixel too much, I will
> check  that.
>

Okay. Maybe we should add a little comment there.

Boudewijn


More information about the kimageshop mailing list