Bug 90456 -- manipulating locked/invisible layers.
boud at valdyas.org
Fri May 27 10:54:54 CEST 2005
The reporter of http://bugs.kde.org/show_bug.cgi?id=90456 today brought the
bug back to my attention. I had completely forgotten it, and indeed, it
doesn't even show up in our TODO-1.4.
It's about making layers visible/invisible and locked/unlocked. Briefly, a
layer that is invisible or locked should not be modified by tools, filters,
transforms. Currenly no such check is in place and worse, we generally work
not on KisLayer but on KisPaintDeviceSP which has no locked/invisible
attribute. Same with linked/unlinked -- we don't honour that property either.
Now I tried to find a quick fix, like making it impossible to select an
invisible/locked layer in the layerbox -- but that doesn't work for
transforms applied to the entire image -- or modifying every layer access to
include a check for locked. That fails because we mostly don't work on
So I guess that this is a bug we'll be shipping on Monday, which gives us time
to think of a plan. Scattering the codebase with (if !dev->isLocked() &&
dev->isVisible()) seems like a bad idea to me, because we're bound to forget
a few spots. There must be a better way
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20050527/9431f631/attachment.pgp
More information about the kimageshop