Crash with rectangular select

[Sven Langkamp]

Am Dienstag, 17. Mai 2005 15:40 schrieb Boudewijn Rempt:
> I'm trying to assess where Krita stands after two weeks of really hard
> working, so I might have missed some work-in-progress -- so if this is old
> news, just tell me.
>
> Anyway, I get a pretty predictable crash when trying to use the rectangular
> select tool with the most recent svn version:
>
> #4  0xb6492955 in KisPainter::begin () from /usr/lib/libkritacommon.so.1
> #5  0xb6492042 in KisPainter::KisPainter () from
> /usr/lib/libkritacommon.so.1 #6  0xb645c6d1 in KisPaintDevice::addSelection
> ()
>    from /usr/lib/libkritacommon.so.1
> #7  0xb5d28b71 in KisToolSelectRectangular::buttonRelease ()
>    from /usr/lib/kde3/kritaselectiontools.so
> #8  0xb6486f16 in KisView::canvasGotButtonReleaseEvent ()
>    from /usr/lib/libkritacommon.so.1
> #9  0xb648d3a2 in KisView::qt_invoke () from /usr/lib/libkritacommon.so.1
> #10 0xb73de067 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
> #11 0xb64f8d6d in KisCanvas::gotButtonReleaseEvent ()
>    from /usr/lib/libkritacommon.so.1
> #12 0xb64f6a16 in KisCanvas::buttonReleaseEvent ()
>    from /usr/lib/libkritacommon.so.1
> #13 0xb64f6513 in KisCanvas::mouseReleaseEvent ()
>    from /usr/lib/libkritacommon.so.1
> #14 0xb74117e9 in QWidget::event () from /usr/lib/libqt-mt.so.3
> #15 0xb7386370 in QApplication::internalNotify () from
> /usr/lib/libqt-mt.so.3 #16 0xb7385ac7 in QApplication::notify () from
> /usr/lib/libqt-mt.so.3 #17 0xb78d6960 in KApplication::notify () from
> /usr/lib/libkdecore.so.4 #18 0xb731f12f in QETWidget::translateMouseEvent
> ()
>    from /usr/lib/libqt-mt.so.3
> #19 0xb731ce1c in QApplication::x11ProcessEvent () from
> /usr/lib/libqt-mt.so.3 #20 0xb7332ec2 in QEventLoop::processEvents () from
> /usr/lib/libqt-mt.so.3 #21 0xb739774c in QEventLoop::enterLoop () from
> /usr/lib/libqt-mt.so.3 #22 0xb739760e in QEventLoop::exec () from
> /usr/lib/libqt-mt.so.3
> #23 0xb738657b in QApplication::exec () from /usr/lib/libqt-mt.so.3
> #24 0xb7fe538a in kdemain () from /usr/lib/libkdeinit_krita.so
> #25 0xb7fe7996 in kdeinitmain () from /usr/lib/kde3/krita.so
>
> Does this ring any bells?

Seems to be caused by this:
> SVN commit 414895 by boemann:
> 
> changed select rect to use actions again
> changed select rect and select contiguous to first invert when 
> SELECTION_SUBTRACT and deselected to begin with

Looks to me like the temp selection is added to the selection of the 
selection:
> +                                       case SELECTION_ADD:
> 
+                                               selection->addSelection(tmpSel);
> +                                               break;
> +                                       case SELECTION_SUBTRACT:
> 
+                                               selection->subtractSelection(tmpSel);
> +                                               break;
> +                                       default:
> +                                               break;