iterators

[Casper Boemann]

you're wellcome to commit

regarding the error - I have it myself - though I thought I provoked it
after I send the diff , but I guess not.

It's caused  by the include hell we have :-/

paindevice.h includes iterators_pixel.h which includes pixel.h
and pixel.h includes selection.h which includes paintdevice.h

The circle is thus closed and at the time of defining selection paintdevice
is not yet defined.

The fix would be not to include selection.h in pixel.h. Rather we should
include colorspace_alpha to get the info we need (possible move some
defines)

hope this explains

best regards
Casper

----- Original Message ----- 
From: "Boudewijn Rempt" <boudewijn at tryllian.com>
To: "For developers of Krayon (previously known as KImageShop)"
<kimageshop at kde.org>
Sent: Friday, January 21, 2005 9:43 AM
Subject: Re: iterators


> On Thursday 20 January 2005 23:57, Casper Boemann wrote:
>
> > diff and new files attached - so everybody please audit - and answer
> > quickly as I'll be away friday noon till sunday noon and it would be
nice
> > to commit before then.
>
> I'm looking at it, but I cannot get it to compile yet -- possibly an
> interference with a bit of work I was doing myself, but I'm not sure.
>
> make[4]: Entering directory
> `/home/boud/prj/krita/koffice-build/krita/ui/widgets'
> if /bin/sh ../../../libtool --silent --tag=CXX --mode=compile g++
> -DHAVE_CONFIG_H -I. -I../../../../koffice/krita/ui/widgets -I../../..
> -I../../../../koffice/krita/ui/widgets/../
> -I../../../../koffice/krita/ui/widgets/../../core/
> -I../../../../koffice/krita/ui/widgets/../../core/color_strategy
> -I../../../../koffice/krita/ui/widgets/../../core/resources
> -I../../../../koffice/krita/ui/widgets/../../core/compositeop
> -I../../../../koffice/krita/ui/widgets/../../core/paintop
> -I../../../../koffice/krita/ui/widgets/../../core/tool
> -I../../../../koffice/krita/ui/widgets/../../core/tiles
> -I../../../../koffice/lib/kofficeui -I../../../lib/kofficeui
> -I../../../../koffice/lib/kofficecore -I../../../lib/kofficecore
> -I../../../../koffice/lib/store -I../../../lib/store
> -I../../../../koffice/lib/kwmf -I../../../lib/kwmf
> -I../../../../koffice/lib/interfaces -I../../../../koffice/lib/kopainter
> -I../../../lib/kopainter -I/opt/kde3/include -I/usr/lib/qt3/include
> -I/usr/X11R6/include   -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wnon-virtual-dt
or
> -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-alig
n
> -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -O
2
> -Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-ne
w
> -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL
> -DQT_NO_COMPAT -DQT_NO_TRANSLATION  -MT kis_multi_integer_filter_widget.lo
> -MD -MP -MF ".deps/kis_multi_integer_filter_widget.Tpo" -c -o
> kis_multi_integer_filter_widget.lo
../../../../koffice/krita/ui/widgets/kis_multi_integer_filter_widget.cc;
> \
> then mv -f ".deps/kis_multi_integer_filter_widget.Tpo"
> ".deps/kis_multi_integer_filter_widget.Plo"; else rm -f
> ".deps/kis_multi_integer_filter_widget.Tpo"; exit 1; fi
> In file included from ../../../../koffice/krita/core/kis_pixel.h:29,
>                  from
../../../../koffice/krita/core/kis_iteratorpixeltrait.h:25,
>                  from
../../../../koffice/krita/core/kis_iterators_pixel.h:24,
>                  from
../../../../koffice/krita/core/kis_paint_device.h:35,
>                  from ../../../../koffice/krita/core/kis_layer.h:21,
>                  from ../../../../koffice/krita/core/kis_filter.h:30,
>                  from
../../../../koffice/krita/ui/widgets/kis_multi_integer_filter_widget.cc:26:
> ../../../../koffice/krita/core/kis_selection.h:44: error: base class `
>    KisPaintDevice' has incomplete type
> make[4]: *** [kis_multi_integer_filter_widget.lo] Error 1
> make[4]: Leaving directory
> `/home/boud/prj/krita/koffice-build/krita/ui/widgets'
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory `/home/boud/prj/krita/koffice-build/krita/ui'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/home/boud/prj/krita/koffice-build/krita'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/boud/prj/krita/koffice-build'
> make: *** [all] Error 2
>
> Shall I commit if I don't get it to compile before you've gone?
> _______________________________________________
> kimageshop mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>