Update on autolayers merge

[Boudewijn Rempt]

On Wed, 19 Jan 2005, Bart Coppens wrote:

> On Wednesday 19 January 2005 09:51, Boudewijn Rempt wrote:
>
> > ./core/kis_fill_painter.cc
> > * Fix fillRect by implementing clear.
> What do you mean by this? As far as I can see this code doesn't use clear.

At the moment filling a rect is done with the iterators -- it can be done
much faster by implementing clear & paste in the data manager and calling that.

> The crashing of the floodfill is caused by a not entirely optimal algortithm
> that's being used. The current algorithm can cause a stack overflow in really
> suboptimal cases. I could have a look around to find a better algorithm for
> this.

Okay... That explains why it only happens reproducibly in the performance tests. I guess
that floodfilling an empty image is a bad idea :-).

> This code used the infinite iterators, so I decided to wait with fixing the
> pattern fill until there were new iterators for iterating over a pattern. But
> maybe I could try to work around that for now. If filling a rectangle with a
> pattern is fixed, fixing the floodfill would probably only require
> uncommenting the code for it.

Well, that's easy enough: just a repeated bitBlt.