[PATCH] make ellipse/rectangle/star draggable (Alt), and resizable as square (Shift)

Boudewijn Rempt boud at valdyas.org
Sat Apr 16 19:25:06 CEST 2005


On Saturday 16 April 2005 19:05, Melchior FRANZ wrote:
> * Boudewijn Rempt -- Saturday 16 April 2005 18:49:
> > I'll commit tonight. Or you can do so yourself if you've got a cvs
> > account.
>
> Done. I'm always happy if I can commit something. Someone might else
> consider to cancel my account/mail address. And yes, I only did it,
> so I could whine about all the minor bugs -- now that I'm a
> *contributor*!  ;-)

I'll add you to the about box :-).

> Same should be done with the cirle/rectangle select tool. Doesn't look
> overly complicated, but there is a lot of commented out code in one
> of the files so that I didn't want to mess with it. Also, the selection
> is currently worked on, it seems. (Heh, and then there's feature freeze,
> isn't it?)

Ah, yes -- but if it's _bugs_ you're fixing... Like make the user interface
more consistent while at the same time not introducing new translation 
strings... Then I guess we'd jump at someone doing the work right away.

When working on tools that have been in Krita for about six years, and that
have not been maintaied any too well, you'll probably find cruft. Some of the 
commented out code should be activated once the optionwidget code is done: 
that is to say, there's already a .ui file for the shape tools that allows 
the user to choose opacity, composition rules and fill rules -- 
wdgshapeoptions.ui. This file was present before the freeze and so is 
probably translated.

It needs to be used in exactly the same way as the other option widgets, for 
instance those in the brush or the gradient tool. The commented out code 
about opacity etc. can then be linked to the relevant widgets.

The only reason I haven't yet added the widget is that I haven't got a clue 
about how to make an ellipse filled with a pattern or a colour...

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20050416/ca2b09d7/attachment.pgp


More information about the kimageshop mailing list