Back

[Boudewijn Rempt]

I'm really back -- I've compiled Krita again, and am trying to merge my 
holiday work on histograms -- the little I managed to do in between walking 
an lush green forests, visiting quaint old Thuringian towns and speaking 
German with very friendly Germans.

Anyway, I notice we have a nice new set of iterators. Still line-oriented, 
though, not rect, which I think is a pity. Cool matrix class, lots of changes 
to tablet support. Something happened to colour spaces that I haven't got the 
depth of yet -- but it looks a lot more dynamic than it was.

I've got one or two problems, though: the way iterators are used in 
KisHistogram since the latest change means computing histograms crashes:

		KisIteratorLinePixel lineIt = m_layer -> iteratorPixelSelectionBegin(0);
		KisIteratorLinePixel lastLine = m_layer -> iteratorPixelSelectionEnd(0);
		Q_INT32 depth = m_layer -> depth();
		while( lineIt <= lastLine )
		{
			KisIteratorPixel pixelIt = *lineIt;
			KisIteratorPixel lastPixel = lineIt.end();
			while( pixelIt <= lastPixel )
			{
				for( int i = 0; i < depth; i++)
				{
 					// Do computing
 					if (i == channel.pos()) {
 						KisQuantum datum = pixelIt[channel.pos()];
// 						m_values[datum] = m_values[datum]++;
// 						if (datum > m_max) m_max = datum;
// 						if (datum < m_min) m_min = datum;
// 						total += datum;
 						m_count++;
 					}
					++pixelIt;
				}
				++pixelIt;
			}
			++lineIt;
		}

I take it we have to use another way of accessing the relevant channel, but 
since this API is brand new, I don't know how.

The second thing is that I notice some compilation warnings to do with 
templates that rather worry me. (gcc 3.3.3).

Thirdly, even though I can compile Krita without problems, Brad Hards mailed 
me with a possible dependency problem in designerplugin, which is new to me, 
too:

----------------

Making all in designerplugin
make[2]: Entering directory 
`/home/bradh/coding/cvs-vers/kde/koffice/krita/ui/designerplugin'
if /bin/sh ../../../libtool --silent --mode=compile --tag=CXX g++ 
-DHAVE_CONFIG_H -I. -I. -I../../.. -I./.. -I./../../core 
-I./../../core/compositeop -I./../../core/color_strategy -I./../../core/tiles 
-I../../../lib/kofficeui -I../../../lib/kofficeui -I../../../lib/kofficecore 
-I../../../lib/kofficecore -I../../../lib/store -I../../../lib/store 
-I../../../lib/kwmf -I../../../lib/kwmf -I../../../lib/kopainter 
-I../../../lib/kopainter -I/usr/lib/qt-3.3/include -I/usr/X11R6/include   
-DQT_THREAD_SUPPORT  -D_REENTRANT -DQT_PLUGIN -Wnon-virtual-dtor 
-Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align 
-Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -O2 
-Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-new 
-fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL 
-DQT_NO_COMPAT -DQT_NO_TRANSLATION  -MT kis_widgets_plugin.lo -MD -MP -MF 
".deps/kis_widgets_plugin.Tpo" \
  -c -o kis_widgets_plugin.lo `test -f 'kis_widgets_plugin.cc' || echo 
'./'`kis_widgets_plugin.cc; \
then mv -f ".deps/kis_widgets_plugin.Tpo" ".deps/kis_widgets_plugin.Plo"; \
else rm -f ".deps/kis_widgets_plugin.Tpo"; exit 1; \
fi
make[2]: *** No rule to make target `../../libkritacommon.la', needed by 
`kritawidgets.la'.  Stop.
make[2]: Leaving directory 
`/home/bradh/coding/cvs-vers/kde/koffice/krita/ui/designerplugin'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/bradh/coding/cvs-vers/kde/koffice/krita/ui'
make: *** [all-recursive] Error 1

It looks like some kind of dependency problem - 
libkritacommon.la depends on core/libkritacore.la ui/libkisui.la 
tools/libkistools.la, so 
krita/core, krita/ui and kritatools need to be before krita/., but 
ui/designerplugin/kritawidgets.la depends on libkritacommon.la.

Maybe we need to move krita/ui/designerplugin to krita/designerplugin? Can you
take a look?

-----

For the rest, I feel my absence has moved Krita a lot in the direction of a 
first alpha -- shall I take another holiday?



-- 
Boudewijn Rempt | http://www.valdyas.org/fading/index.cgi