koffice/krita

[Bart Coppens]

Quoting Boudewijn Rempt <boud at valdyas.org>: 
> virtual void KisStrategyColorSpace::bitBlt(Q_INT32 stride, 
> virtual void KisStrategyColorSpace::bitBlt(Q_INT32 stride, 
 
Wouldn't it be better to have these return a boolean or some sort of error 
code? So plugins and other code can try to use a composite op, and know 
immediately if it failed (because the strategy doesn't support this 
operation). You could let the calling code do this check, but that would lead 
to code duplication, I think. 
 
> is all the API I want the color strategies to expose to the rest of Krita. 
 
I agree that the API for color strategies should be minimal, but with only 
these functions you'll miss certain functionality (think of the 
KisToolFill::difference function), that should either depend on the strategy 
directly, or indirectly through KoColor (depending on how colors will be 
implemented). 
 
Bart Coppens