KHTML, KJS Unfrozen -- details

[Frans Englich]

On Wednesday 15 February 2006 21:52, George Staikos wrote:
> On Wednesday 15 February 2006 16:23, Maciej Stachowiak wrote:
> > On Feb 15, 2006, at 2:04 AM, David Faure wrote:
> > > /devel/kde/src/4/kdelibs/kjs/interpreter.h:379: warning: unused
> > > parameter ‘v’
> > > /devel/kde/src/4/kdelibs/kjs/interpreter.h:388: warning: unused
> > > parameter ‘imp’
> > > /devel/kde/src/4/kdelibs/kjs/interpreter.h:396: warning: unused
> > > parameter ‘target’
> >
> > George replied about the compiler warnings, for unused parameters I
> > would rather remove the parameter name. A patch for this would be
> > really helpful. If not, I'll try turning on -Wunused sometime in our
> > project, hopefully this won't break too bad on PCRE.
>
>   A nice thing about Q_UNUSED is that in the future when the parameter
> becomes meaningful to use, you know that it's there and being used
> properly.

Which I as well was just about to say. Another aspect is that removing 
parameter names because the code doesn't need them breaks Doxygen 
documentation, since it uses the parameter names for the @param tag.

Perhaps Q_UNUSED could be added to KWQ/Webkit.


Cheers,

		Frans