KHTML, KJS Unfrozen -- details

[David Faure]

On Wednesday 15 February 2006 08:01, Maciej Stachowiak wrote:
> Are there more?

Well we really need to get rid of all the compiler-warnings that the new kjs introduces,
but I think George is already talking to you about that.

/devel/kde/src/4/kdelibs/kjs/fpconst.cpp:34:5: warning: "__APPLE__" is not defined
compiling /devel/kde/src/4/kdelibs/kjs/ustring.cpp
In file included from /devel/kde/src/4/kdelibs/kjs/ustring.cpp:25:
/devel/kde/src/4/kdelibs/kjs/ustring.h:33:5: warning: "__APPLE__" is not defined
In file included from /devel/kde/src/4/kdelibs/kxmlcore/Vector.h:26,
                 from /devel/kde/src/4/kdelibs/kjs/ustring.cpp:43:
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:38:6: warning: "__APPLE__" is not defined
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:134:5: warning: "ASSERTIONS_DISABLED_DEFAULT" is not defined
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:151:5: warning: "ASSERTIONS_DISABLED_DEFAULT" is not defined
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:162:5: warning: "ASSERTIONS_DISABLED_DEFAULT" is not defined
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:170:5: warning: "ASSERTIONS_DISABLED_DEFAULT" is not defined
compiling /devel/kde/src/4/kdelibs/kjs/collector.cpp
In file included from /devel/kde/src/4/kdelibs/kjs/value.h:41,
                 from /devel/kde/src/4/kdelibs/kjs/collector.h:27,
                 from /devel/kde/src/4/kdelibs/kjs/collector.cpp:23:
/devel/kde/src/4/kdelibs/kjs/ustring.h:33:5: warning: "__APPLE__" is not defined
In file included from /devel/kde/src/4/kdelibs/kxmlcore/HashCountedSet.h:26,
                 from /devel/kde/src/4/kdelibs/kjs/collector.cpp:26:
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:38:6: warning: "__APPLE__" is not defined
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:134:5: warning: "ASSERTIONS_DISABLED_DEFAULT" is not defined
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:151:5: warning: "ASSERTIONS_DISABLED_DEFAULT" is not defined
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:162:5: warning: "ASSERTIONS_DISABLED_DEFAULT" is not defined
/devel/kde/src/4/kdelibs/kxmlcore/Assertions.h:170:5: warning: "ASSERTIONS_DISABLED_DEFAULT" is not defined
In file included from /devel/kde/src/4/kdelibs/kxmlcore/HashMap.h:26,
                 from /devel/kde/src/4/kdelibs/kxmlcore/HashCountedSet.h:27,
                 from /devel/kde/src/4/kdelibs/kjs/collector.cpp:26:
/devel/kde/src/4/kdelibs/kxmlcore/HashTable.h:36:5: warning: "NDEBUG" is not defined
/devel/kde/src/4/kdelibs/kjs/collector.cpp:34:5: warning: "__APPLE__" is not defined
/devel/kde/src/4/kdelibs/kjs/collector.cpp:195:5: warning: "KJS_MULTIPLE_THREADS" is not defined
/devel/kde/src/4/kdelibs/kjs/collector.cpp:304:5: warning: "__APPLE__" is not defined
/devel/kde/src/4/kdelibs/kjs/collector.cpp:341:5: warning: "KJS_MULTIPLE_THREADS" is not defined
/devel/kde/src/4/kdelibs/kjs/collector.cpp:388:5: warning: "KJS_MULTIPLE_THREADS" is not defined
/devel/kde/src/4/kdelibs/kjs/collector.cpp:518:6: warning: "DEBUG_COLLECTOR" is not defined
/devel/kde/src/4/kdelibs/kjs/collector.cpp:543:5: warning: "DEBUG_COLLECTOR" is not defined
/devel/kde/src/4/kdelibs/kjs/collector.cpp:609:5: warning: "APPLE_CHANGES" is not defined
/devel/kde/src/4/kdelibs/kjs/interpreter.h:379: warning: unused parameter ‘v’
/devel/kde/src/4/kdelibs/kjs/interpreter.h:388: warning: unused parameter ‘imp’
/devel/kde/src/4/kdelibs/kjs/interpreter.h:396: warning: unused parameter ‘target’
etc.

Please use #ifdef instead of #if for symbols that are not always defined.
For the unused parameters, (void)v is the portable solution (other than removing
the variable name from the signature). I can provide a patch if you say OK to the change,
but I guess you can just go ahead and do the change in jscore directly...

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).