patch: correctness of <script> tag attributes

John Sullivan sullivan at apple.com
Fri Sep 24 04:19:43 CEST 2004


We discovered a web page that hangs in an infinite JavaScript loop that 
doesn't hang on other browsers because the <script> tag had a 
deliberately bad value for its language attribute of 
"disabled_JavaScript". Our test for valid values of the language and 
type attributes of the <script> tag was much more permissive than other 
browsers, so we accepted "disabled_JavaScript" as a valid value.

Here's the patch, and a test page that shows a variety of values of 
"language" and "type" that can be compared against different browsers.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: scripttag.patch
Type: application/octet-stream
Size: 4699 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/khtml-devel/attachments/20040923/6c7d934b/scripttag.obj
-------------- next part --------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: javascript_type_test.html
Type: application/applefile
Size: 479 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/khtml-devel/attachments/20040923/6c7d934b/javascript_type_test.bin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/khtml-devel/attachments/20040923/6c7d934b/javascript_type_test.html
-------------- next part --------------


The page that was hanging before this fix is http://www.riibe.com

John


More information about the Khtml-devel mailing list