Patch for HTMLInputElementImpl::reset()

David Faure faure at kde.org
Sun Oct 24 17:41:34 CEST 2004


In WebCore 146.1, html_formimpl.cpp says:

void HTMLInputElementImpl::reset()
{
    setValue(DOMString());
   [...]
}

This breaks regression/tests/mozilla/dom/dom-html/hfor009.html which says
<form name="Bands">
<input name="John" type="text" value="John">
</form>
<script>
document.Bands.John.value="Johnny";
document.Bands.reset();
</script>

document.Bands.John.value is then expected to be "John" again,
but the above code sets it to empty.

This fixes it:
    setValue(getAttribute(ATTR_VALUE));

Is this fixed already in WebCore? Can I have any patch related to html_formimpl.cpp
between WebCore-146 and now? - or an updated tarball altogether? Thanks.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


More information about the Khtml-devel mailing list