patch: correctness of <script> tag attributes

David Faure faure at kde.org
Thu Oct 14 21:01:18 CEST 2004


On Friday 24 September 2004 04:19, John Sullivan wrote:
> We discovered a web page that hangs in an infinite JavaScript loop that 
> doesn't hang on other browsers because the <script> tag had a 
> deliberately bad value for its language attribute of 
> "disabled_JavaScript". Our test for valid values of the language and 
> type attributes of the <script> tag was much more permissive than other 
> browsers, so we accepted "disabled_JavaScript" as a valid value.
> 
> Here's the patch, and a test page that shows a variety of values of 
> "language" and "type" that can be compared against different browsers.

Thanks a lot for the patch and analysis. Merged, tested and committed.

(This DomStringImpl::value() method must be new in safari, I had to use
DOMString(a).string())

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


More information about the Khtml-devel mailing list