patch to fix bug with long hexadecimal entities

Zack Rusin zack at kde.org
Tue Jun 8 21:05:29 CEST 2004


On Tuesday 08 June 2004 12:46, Darin Adler wrote:
> On Jun 8, 2004, at 9:02 AM, Zack Rusin wrote:
> > did it really fix anything? If you'd have a testcase that would of
> > course help immensly :)
>
> The test case was <http://www.alanwood.net/unicode/deseret.html>.

Thanks! Just committed it. I of course have my counting problems, 
increment of cBufferPos in searchentity and numericsearch and then 
subtraction of 2 from 9 kinda doesn't give "also 8" :) 
For the consitency with the rest of the code in there we really should 
have 10 - cbufferpos since the 10 is the max entity length then, but I 
don't think anyone will argue having just 8 whuch seems natural for hex 
there considering that you're not the only one who was scratching 
his/hers head when looking at that code trying to figure out what it 
does.

Zack

-- 
"The number of UNIX installations has grown to 10, with more
expected." (6/72) 


More information about the Khtml-devel mailing list