patch: stub implementation of XMLHttpRequest
Maciej Stachowiak
mjs at apple.com
Tue Feb 24 04:06:02 CET 2004
On Feb 23, 2004, at 6:57 PM, Dirk Mueller wrote:
> On Monday 23 February 2004 23:52, Maciej Stachowiak wrote:
>
>> http://www.mozilla.org/xmlextras/tests.html
>
> Ah, very nice. Ok, the easy tests now work here too, except the
> synchronous IO
> part which I don't care about for now. The only small incompatibility
> is that
> in our implementation, you have to pass
>
> job->addMetaData( "PropagateHttpHeader", "true" );
>
> to be able to query the HTTP headers afterwards, so I added this to
> "send()".
> Maybe you want to merge that, even if it doesn't make a difference in
> your
> code.
Sure, I'll add it and it can be a no-op.
> I didn't yet figure out why you have "toString" and "toHTML" in your
> tree... I
> would consider merging those two. Any reasons why that hasn't been
> done?
Stupidity on my part. I will be merging them soon. I'll make sure to
send a patch when I do it.
> Also, what surprises me is that you compare the portnumbers in the
> domain
> check. we don't do that for the usual "domain" checks. Reading your
> code, you
> apparently don't do that either. Any known reason for that?
Honstly, I don't remember. It may have been based on testing other
browsers.
It would be good to be consistent about this, although already by
default cookies are separate for different ports on the same host,
while XSS allows access.
Regards,
Maciej
More information about the Khtml-devel
mailing list