faster paint tree traversal

Dirk Mueller mueller at kde.org
Wed Feb 11 14:36:08 CET 2004


On Wednesday 11 February 2004 09:49, David Hyatt wrote:

> Here's my cut at a merge.  I had to do things a bit differently for
> tables because of the collapsed border code in RenderTableCell's paint
> method.  I made a non-virtual paintObject method for RenderBlock so
> that I could basically leave RenderBlock and RenderTableCell the way
> they were.

You're right, that hurts a bit. I'm fine with your version, and will look into 
merging it. 

> I noticed in your patch that you replaced
> _y + _h
> r.bottom()
> If I'm reading the Qt docs correctly, I think this is going to
> introduce a 1 pixel error, since a 16px high rectangle at a ypos of 0
> would have a bottom ypos point of 15 (not 16).

you're correct about the 15/16 difference, but IMHO this is actually fixing 
the off-by-one that was there before, since y+h is the first pixel row 
*outside* the box, so comparing with "> _ty" is wrong (unless I'm lacking way 
too much sleep now). correct?


Dirk


More information about the Khtml-devel mailing list