[patch] don't restart marquee if it's suspended

Dave Hyatt hyatt at apple.com
Fri Aug 20 19:47:56 CEST 2004


This fix is incorrect though, since it effectively prevents the marquee 
from resuming at all.  When you go to another page and then hit back, 
the marquee should resume.  This may only be an issue with WebCore, 
since we have a back/forward cache.

dave

On Aug 20, 2004, at 10:42 AM, Dave Hyatt wrote:

> Yes, WebCore is affected.  Thanks for the fix.
>
> dave
>
> On Aug 20, 2004, at 6:50 AM, Leo Savernik wrote:
>
>> Hello,
>>
>> I found the following issue in the marquee implementation:
>>
>> When a marquee is suspended, it will be started unconditionally as 
>> soon as
>> updateMarqueePosition is called.
>>
>> You can test this on [1] where clicking on "stop" would suspend the 
>> marquee,
>> but only until the next relayout occurred, which in turn called
>> updateMarqueePosition, which in turn called start().
>>
>> WebCore might be affected, too.
>>
>> mfg
>>  Leo
>>
>> [1] http://javascriptkit.com/javatutors/marquee4.shtml
>> <khtml_marquee_5.diff>_______________________________________________
>> Khtml-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/khtml-devel
>
> _______________________________________________
> Khtml-devel at kde.org
> https://mail.kde.org/mailman/listinfo/khtml-devel



More information about the Khtml-devel mailing list