Bug in Safari's residual style code

David Hyatt hyatt at apple.com
Wed Sep 3 16:06:54 CEST 2003


The code that built up the residualStyleStack was buggy.  Here's a diff 
against the Safari tree.

-------------- next part --------------
Index: khtml/html/htmlparser.cpp
===================================================================
RCS file: /local/home/cvs/Labyrinth/WebCore/khtml/html/htmlparser.cpp,v
retrieving revision 1.55
diff -u -p -r1.55 khtml/html/htmlparser.cpp
--- khtml/html/htmlparser.cpp	2003/07/30 00:39:43	1.55
+++ khtml/html/htmlparser.cpp	2003/09/03 20:32:46
@@ -1493,12 +1493,9 @@ void KHTMLParser::popBlock( int _id )
                 // Elem->id rather than the node that you should pop to when the element gets pulled off
                 // the stack.
                 popOneBlock(false);
-                Elem->next = 0;
+                Elem->next = residualStyleStack;
                 Elem->node = currNode;
-                if (!residualStyleStack)
-                    residualStyleStack = Elem;
-                else
-                    residualStyleStack->next = Elem;
+                residualStyleStack = Elem;
             }
             else
                 popOneBlock();
-------------- next part --------------


dave


More information about the Khtml-devel mailing list