patch: fix for regression from cancelBubble patch

Maciej Stachowiak mjs at apple.com
Thu Oct 30 08:41:07 CET 2003


It's nice to initialize new data members:

-------------- next part --------------
Index: ChangeLog
===================================================================
RCS file: /local/home/cvs/Labyrinth/WebCore/ChangeLog,v
retrieving revision 1.2151
diff -u -p -r1.2151 ChangeLog
--- ChangeLog	2003/10/30 05:45:47	1.2151
+++ ChangeLog	2003/10/30 06:36:27
@@ -1,3 +1,12 @@
+2003-10-29  Maciej Stachowiak  <mjs at apple.com>
+
+        Reviewed by NOBODY (OOPS!).
+
+	- fixed 3467499 - REGRESSION: onClick handlers on links don't work (bubbling broken)
+	
+        * khtml/xml/dom2_eventsimpl.cpp:
+        (EventImpl::EventImpl): Initialize m_cancelBubble (duh).
+
 2003-10-29  David Hyatt  <hyatt at apple.com>
 
 	Fix for 3466802.  When breaking on a newline, "pre" is determined by checking the actual object that
Index: khtml/xml/dom2_eventsimpl.cpp
===================================================================
RCS file: /local/home/cvs/Labyrinth/WebCore/khtml/xml/dom2_eventsimpl.cpp,v
retrieving revision 1.12
diff -u -p -r1.12 khtml/xml/dom2_eventsimpl.cpp
--- khtml/xml/dom2_eventsimpl.cpp	2003/10/20 17:28:10	1.12
+++ khtml/xml/dom2_eventsimpl.cpp	2003/10/30 06:36:36
@@ -42,6 +42,7 @@ EventImpl::EventImpl()
 
     m_propagationStopped = false;
     m_defaultPrevented = false;
+    m_cancelBubble = false;
     m_id = UNKNOWN_EVENT;
     m_currentTarget = 0;
     m_eventPhase = 0;
@@ -61,6 +62,7 @@ EventImpl::EventImpl(EventId _id, bool c
 
     m_propagationStopped = false;
     m_defaultPrevented = false;
+    m_cancelBubble = false;
     m_id = _id;
     m_currentTarget = 0;
     m_eventPhase = 0;
-------------- next part --------------


  - Maciej


More information about the Khtml-devel mailing list