patch: click event handling

David Faure faure at kde.org
Wed Oct 29 07:49:03 CET 2003


On Tuesday 28 October 2003 23:25, Maciej Stachowiak wrote:
> 
> Here's a patch to make click handlers added w/ addEventListener work 
> right for form controls.

Thanks, I'll have a look.

Another problem with click event handling: in the branch (so I suppose in Safari too),
if you click twice, rather slowly, at the very same place, you get the onclick
listener called only once. This is due to wrong code for detecting click vs dblclick.

For the chosen solution and why, see the comment in the attached patch 
(note that the "-" lines in handleLocalEvents won't match yours, there was a 
different change made to HEAD previously, but it was wrong).

-- 
David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: onclick_fix.diff
Type: text/x-diff
Size: 7928 bytes
Desc: not available
Url : http://mail.kde.org/mailman/private/khtml-devel/attachments/20031029/a9864f95/onclick_fix-0001.bin


More information about the Khtml-devel mailing list