patch: kjs recursion limit fix

porten at froglogic.com porten at froglogic.com
Wed Oct 29 02:39:17 CET 2003


On Tue, 28 Oct 2003, Maciej Stachowiak wrote:

> > Note: we have moved this code to Object::call() in the middle of last
> > year. I don't recall the concrete test case back then but I would
> > guess it
> > was something like
>
> OK, I'll look for your change in the kdelibs tree and see if I can
> figure it out.

It can be found at the tip of the 3.0 branch.

http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/kjs/nodes.cpp?only_with_tag=KDE_3_0_BRANCH
http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/kjs/object.cpp?only_with_tag=KDE_3_0_BRANCH

The idea behind it is to move the check to a lower level so that internal
recursions are caught as well.

What just amazed be is that Mozilla doesn't throw an error on my previous
test case at all. They probably have a different way of detecting
recursive references in arrays.

Harri.



More information about the Khtml-devel mailing list