ArgumentsNode::reverseList()

[Maciej Stachowiak]

On Oct 26, 2003, at 4:14 PM, porten at froglogic.com wrote:

> On Sun, 26 Oct 2003, Maciej Stachowiak wrote:
>
>> Did you measure what effect it has on performance?
>
> No. I just looked at the number of comparable statements and concluded
> that there were fewer (plus a function call less). I know, I know, one
> shouldn't assume anything. Do you have any doubt that it made any 
> positive
> difference ? In this case I'd do a measurement.

I don't really have any guesses one way or the other. On the Safari 
team, we always measure before and after when we make a change that we 
think will affect performance, so I ask people about it out of habit.

>> Also, I think the circular list trick is worthy of a comment 
>> somewhere,
>> for the benefit of future generations of programmers.
>
> Yeah. I had added the comment with the previous patch (last year?) but 
> I
> admit that this trick is hard to understand. I'll see that this is
> properly documented.

Great.

>
>> I'd definitely like to see the full patch.
>
> Will do once I get around finishing the rest.

Thanks!

  - Maciej