webcore 106 color handling changes

Dirk Mueller mueller at kde.org
Sat Oct 25 18:57:06 CEST 2003


Hi,

--- WebCore-old/khtml/misc/helper.h     2003-10-09 21:01:59.000000000 +0200
+++ WebCore/khtml/misc/helper.h 2003-08-04 12:16:06.000000000 +0200
@@ -30,9 +30,8 @@
 namespace khtml
 {
     const QRgb transparentColor = 0x00000000;
-    const QRgb invalidColor     = 0x00000001;
-    const QRgb invertedColor    = 0x00000002;
-    const QRgb defaultTextColor = 0x00000003;
+    const QRgb invertedColor    = 0x00000002; // This really makes no sense. 
This is a valid color value, so why
+                                              // is it being given special 
meaning? -dwh
     
     extern QPainter *printpainter;
     void setPrintPainter( QPainter *printer );


That commit (and the related changes in css/) makes no sense. it is not a 
valid color in our tree, its a fully transparent color. These colors are 
necessary to correctly calculate the default text color (when it is modified 
by external stylesheets) to reset to when a <table> is opened in the html 
compat case. 

It is also necessary to support border: transparent correctly, because there 
is a difference between no color given (which means use the foreground color 
for border) and explicit transparent color. And you have to transport that 
into the rendering tree. 

So unless I miss somthing, this should be reverted.  



-- 
> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for FREE! <


More information about the Khtml-devel mailing list