diff htmltokenizer.h

Dirk Mueller mueller at kde.org
Sat Oct 25 18:59:37 CEST 2003


Hi,

+++ WebCore/khtml/html/htmltokenizer.h  2003-08-04 12:16:06.000000000 +0200
@@ -340,7 +340,10 @@
     int scriptStartLineno;
     int tagStartLineno;
 
-#define CBUFLEN 14
+// This buffer can hold arbitrarily long user-defined attribute names, such 
as in EMBED tags.
+// So any fixed number might be too small, but rather than rewriting all 
usage of this buffer
+// we'll just make it large enough to handle all imaginable cases.
+#define CBUFLEN 1024
     char cBuffer[CBUFLEN+2];
     unsigned int cBufferPos;
 

That again makes no sense at all. the cBuffer is solely used for the 
attrname / tagname to id mapping, done by the gperf generated code in misc/
htmltags.*. 

embed does not use any of those tags. Thats also why it does not matter that 
the "| 0x20" part in htmltokenizer.cpp mangles the '_'. because no valid html 
attribute or tagname that we map to an id has it in its name anyway. I 
checked, no such tags have been added to your tree either. 

-- 
> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for FREE! <


More information about the Khtml-devel mailing list