<button>/<legend>

[Dirk Mueller]

Hi, 

I was surprised to see that the display: inline-block support in your tree 
(v85) was incomplete. I've set the display of button and legend now to 
inline-block and it seems to work fine after some fixes. 

I'm assuming that this is either already in your tree, or if not, what was 
your reason to not do it ?

Oh I also replaced this hack:

bool RenderObject::sizesToMaxWidth() const
{
    return isFloating() || isCompact() ||
      (element() && (element()->id() == ID_BUTTON || element()->id() == 
ID_LEGEND));
}

with proper checks for display inline-block. The method is gone in our tree, 
it was only used from RenderBox::calcWidth and therefore I manually inlined 
it in that place. 


Ah, to answer the fixme in html/html_formimpl.cpp:

void HTMLButtonElementImpl::attach()
{
    // FIXME: This code is repeated here because this method does not call
    // HTMLGenericFormElementImpl::attach(). But it's not clear why the call
    // to updateFromElement() is a problem for the HTMLButtonElementImpl case.
    // If we determine that it's not, then we should remove this and call
    // HTMLGenericFormElementImpl::attach() instead of 
HTMLElementImpl::attach().
    if (!m_form) {
        m_form = getForm();


That code duplication is useless. exactly nothing will happen when 
updateFromElemnt is called and the renderobject derivative doesn't implement 
it. Please clean that up when you have time, thanks.


-- 
> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for FREE! <