Incremental Repainting Patch

[David Hyatt]

That was always a bad change.  It did in fact fix a bug, but it was 
because of a problem in our lower-level code (outside of KHTML) that 
has long since been fixed.  I think this was one of the first 2-3 
changes I made to KHTML after coming to Apple, so it's safe to say I 
had no idea what I was doing at that point. ;)

dave

On Oct 20, 2003, at 12:09 PM, Dirk Mueller wrote:

>
> Hi,
>
> though I never understood the initial reason for these additions in 
> the first
> place, which code change made them obsolete in your tree?
>
>
>
> --- khtml/xml/dom_nodeimpl.cpp  2003/09/19 23:55:42     1.37
> +++ khtml/xml/dom_nodeimpl.cpp  2003/09/26 00:50:20
> @@ -1228,14 +1228,8 @@ NodeImpl *NodeBaseImpl::insertBefore ( N
>
>          // Add child to the rendering tree
>          // ### should we detach() it first if it's already attached?
> -        if (attached() && !child->attached()) {
> +        if (attached() && !child->attached())
>              child->attach();
> -            // This is extremely important, as otherwise a fresh 
> layout
> -            // isn't scheduled, and you end up with stale data 
> (especially
> -            // with inline runs of text). -dwh
> -            if (child->renderer())
> -                child->renderer()->setNeedsLayout(true);
> -        }
>
>          // Dispatch the mutation events
>          dispatchChildInsertedEvents(child,exceptioncode);
> @@ -1302,14 +1296,8 @@ NodeImpl *NodeBaseImpl::replaceChild ( N
>
>          // Add child to the rendering tree
>          // ### should we detach() it first if it's already attached?
> -        if (attached() && !child->attached()) {
> +        if (attached() && !child->attached())
>              child->attach();
> -            // This is extremely important, as otherwise a fresh 
> layout
> -            // isn't scheduled, and you end up with stale data 
> (especially
> -            // with inline runs of text). -dwh
> -            if (child->renderer())
> -                child->renderer()->setNeedsLayout(true);
> -        }
>
>          // Dispatch the mutation events
>          dispatchChildInsertedEvents(child,exceptioncode);
> @@ -1455,14 +1443,8 @@ NodeImpl *NodeBaseImpl::appendChild ( No
>
>          // Add child to the rendering tree
>          // ### should we detach() it first if it's already attached?
> -        if (attached() && !child->attached()) {
> +        if (attached() && !child->attached())
>              child->attach();
> -            // This is extremely important, as otherwise a fresh 
> layout
> -            // isn't scheduled, and you end up with stale data 
> (especially
> -            // with inline runs of text). -dwh
> -            if (child->renderer())
> -                child->renderer()->setNeedsLayout(true);
> -        }
>
>
> -- 
>> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for 
>> FREE! <
> _______________________________________________
> Khtml-devel at mail.kde.org
> http://mail.kde.org/mailman/listinfo/khtml-devel