class Length merge

[David Hyatt]

Should I make the member variables private so that the compiler will 
catch everything?  In the patch it looks like the member variables are 
public still.

On Oct 17, 2003, at 5:51 PM, Dirk Mueller wrote:

>
> Hi,
>
> The attached patch is a diff webcore / khtml tree and adds accessors 
> and
> proper encapsulation to the Length class. This is for several months 
> without
> problems or regressions in our tree, and it would diffing both trees
> significantly easier when this would be merged by you. It also 
> optimizes the
> common construction case by providing a fast path for initializing all 
> member
> variables.
>
> Its not a complete patch, but all other places that need fixing can be 
> found
> by the compiler. For example code like
>
>   if(foo.type == Variable)
>
> is to be replaced with
>
>   if (foo.isVariable())
>
> and code like
>
>   m_width = width.value;
>
> is to be replaced with
>
>   m_width = width.value();
>
>
> I'm looking forward to see this merged in the Apple tree.
>
>
> -- 
>> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for 
>> FREE! <
> <khtmllayout.diff>_______________________________________________
> Khtml-devel at mail.kde.org
> http://mail.kde.org/mailman/listinfo/khtml-devel