handleEvent DOM API breakage

Dirk Mueller mueller at kde.org
Sat Oct 18 04:16:11 CEST 2003


Hi, 

this diff worries me:


--- WebCore/khtml/dom/dom2_events.h· 2003-10-09 21:01:55.000000000 
+++ ./dom2_events.h·    2003-10-18 02:59:21.000000000 +0200
@@ -72,11 +78,8 @@
      * also contains the stopPropagation and preventDefault methods which are
      * used in determining the event's flow and default action.
      *
-     * @param isWindowEvent If true, the "this" should be the window, not the 
current
-     * target (there is no DOM node for the window, so it can't be the 
target).
-     *
      */
-    virtual void handleEvent(Event &evt, bool isWindowEvent);
+    virtual void handleEvent(Event &evt);
·
     /**
      * @internal


it seems you added a second, nonstandard parameter to this handler. Thats both 
binary incompatible and a bug compared to the DOM spec. 

Why did you do that? Is there no better way ?




-- 
> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for FREE! <


More information about the Khtml-devel mailing list